[Webkit-unassigned] [Bug 161493] [FreeType] Incorrect application of glyph positioning in the Y direction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161493

--- Comment #38 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #37)
> I think the problem is that ComplexTextController adds glyph origins to
> their advance in a single advances. But in cairo we need origins and
> advances separately. We need to apply the current origin when drawing, and
> then advance. We are using the current point as origin, and then advancing
> the advance + origin. In these examples there's a y origin we are ignoring.
> 
> So, we have:
> 
> glyphs[i] = { glyphsData[i], xOffset, yOffset };
> xOffset += advances[i].width();
> 
> this should be
> 
> glyphs[i] = { glyphsData[i], xOffset + xOrigin, yOffset + yOrigin };
> xOffset += advances[i].width();
> 
> but we don't have the origins in GlyphBuffer.

Ok, now I understand how the paint advances work. The origins are taken into account in the advances, but we need to use the first origin as the initial advance of the run.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190328/27386d14/attachment-0001.html>