[Webkit-unassigned] [Bug 156774] AX: <svg> elements with labels and no accessible contents are exposed as empty AXGroups

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156774

--- Comment #44 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 366027
  --> https://bugs.webkit.org/attachment.cgi?id=366027
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366027&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3279
> +    if (roleValue() == AccessibilityRole::SVGRoot) {

we should cache the role

auto role = roleValue();

then this should be 

else if (role == AccessibilityRole::SVGRoot && !hasChildren())
   m_role =

> Source/WebCore/accessibility/AccessibilitySVGElement.cpp:251
> +        for (const AccessibilityObject* parent = this; parent; parent = parent->parentObject()) {

can you use the matchedParent closure style

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190327/b1b7817c/attachment.html>