[Webkit-unassigned] [Bug 191646] [Curl] Add Server Trust Evaluation Support.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191646

--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 366052
  --> https://bugs.webkit.org/attachment.cgi?id=366052
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366052&action=review

Just a couple of nitpicks from me.

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:327
> +        m_acceptedServerTrustCert.insert(std::make_pair(host, pem));

If you use emplace() then you don't need make_pair. :)

> Tools/MiniBrowser/win/WebKitBrowserWindow.h:77
> +    std::map<std::wstring, std::wstring> m_acceptedServerTrustCert;

I think this can be unordered_map instead, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190327/52a49bb0/attachment-0001.html>