[Webkit-unassigned] [Bug 195996] Geolocation request not complete when watch request was started in a different web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195996

--- Comment #18 from Sam Weinig <sam at webkit.org> ---
(In reply to Carlos Garcia Campos from comment #16)
> (In reply to Alex Christensen from comment #15)
> > Comment on attachment 365809 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=365809&action=review
> > 
> > > Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp:320
> > > +    std::string alertText;
> > 
> > Nit: I see no reason not to use WTF::String here.
> 
> I'm using std::string only because of Util::toSTD() there isn't a
> Util::toWTF()

If memory serves me, we chose to use std::string in the unit tests because it tended to work well with the unit testing library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190327/cdac1b4d/attachment.html>