[Webkit-unassigned] [Bug 156774] AX: <svg> elements with labels and no accessible contents are exposed as empty AXGroups

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156774

--- Comment #40 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 365973
  --> https://bugs.webkit.org/attachment.cgi?id=365973
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365973&action=review

> Source/WebCore/ChangeLog:6
> +        Labelled SVGs without accessible descendants are exposed as AXImage rather than groups. Unlabelled equivalents are not exposed. Otherwise, SVGs with accessible descendants are exposed as AXGroup

This is an awfully long line. Please hard-wrap the line at the end of the first sentence.

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

This line should appear after the URL but before the long description.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3280
> +        if (!children().size())

Can we just check hasChildren() or do we need to call updateChildrenIfNecessary()?

> Source/WebCore/accessibility/AccessibilitySVGElement.cpp:253
> +            if (parent->hasAttributesRequiredForInclusion())
> +                return false;

Why should hasAttributesRequiredForInclusion returning true on some ancestor affect
whether this SVG shape element will have an accessibility object or not?
That doesn't seem right.

If anything, we need to be checking that descendent nodes are labeled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190326/a74d316f/attachment.html>