[Webkit-unassigned] [Bug 196178] Build failure with gstreamer 1.12.5 if USE_GSTREAMER_GL is enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 26 09:33:09 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=196178

--- Comment #6 from Philippe Normand <pnormand at igalia.com> ---
Can you try this?

diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
index 6d5c7384a2c..9ea5d81e64d 100644
--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
@@ -85,7 +85,6 @@
 #include <gst/gl/gl.h>
 #undef GST_USE_UNSTABLE_API

-#include "GraphicsContext3D.h"
 #include "GLContext.h"
 #if USE(GLX)
 #include "GLContextGLX.h"
@@ -118,6 +117,7 @@
 #if USE(TEXTURE_MAPPER_GL)
 #include "BitmapTextureGL.h"
 #include "BitmapTexturePool.h"
+#include "GraphicsContext3D.h"
 #include "TextureMapperContextAttributes.h"
 #include "TextureMapperGL.h"
 #include "TextureMapperPlatformLayerBuffer.h"
@@ -192,6 +192,9 @@ public:
             if (m_isMapped)
                 m_textureID = *reinterpret_cast<GLuint*>(m_videoFrame.data[0]);
         } else
+#else
+        UNUSED_PARAM(gstGLEnabled);
+        UNUSED_PARAM(flags);
 #endif // USE(GSTREAMER_GL)

         {


Meanwhile I will rollout this patch because I can't test the build with GStreamer 1.12.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190326/d94c9ac8/attachment.html>


More information about the webkit-unassigned mailing list