[Webkit-unassigned] [Bug 186364] [WinCairo] Enable coordinated graphics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186364

--- Comment #23 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 365949
  --> https://bugs.webkit.org/attachment.cgi?id=365949
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365949&action=review

> Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:191
> -#if PLATFORM(GTK)
> +#if !PLATFORM(WPE)

This is exactly what I was going to suggest you to do :-)

> Source/WebKit/WebProcess/WebPage/WebPage.h:960
> -#if PLATFORM(GTK) && USE(TEXTURE_MAPPER_GL)
> +#if PLATFORM(WIN) && USE(TEXTURE_MAPPER_GL)

Why do you remove GTK?

> Source/WebKit/WebProcess/WebPage/WebPage.h:1640
> -#if PLATFORM(GTK) && USE(TEXTURE_MAPPER_GL)
> +#if PLATFORM(WIN) && USE(TEXTURE_MAPPER_GL)

Ditto.

> Source/WebKit/WebProcess/WebPage/win/AcceleratedSurfaceWin.cpp:56
> +void AcceleratedSurfaceWin::initialize()
> +{
> +}
> +
> +void AcceleratedSurfaceWin::finalize()
> +{
> +}

These are not pure virtual, you don't need to override them.

> Source/WebKit/WebProcess/WebPage/win/AcceleratedSurfaceWin.cpp:70
> +void AcceleratedSurfaceWin::willRenderFrame()
> +{
> +}

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190326/a025d27f/attachment-0001.html>