[Webkit-unassigned] [Bug 196016] webkit-patch upload doesn't run 'check-style-local' so doesn't find TestExpectations errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 10:38:20 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=196016

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=148583,
                   |                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=102009

--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
lint-test-expectations doesn't produce the same result as "run-webkit-tests --lint". I have actually never heard of the former, why do we have two ways to lint?

But the difference between two tools seems at best tangentially related to the issue at hand. webkit-patch is supposed to check style by default AFAIK, so it seems surprising that it finds fewer issues than the style EWS.

Funny that we also have bug 102009 which claims that webkit-patch ALWAYS complains about TestExpectations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190322/21e185a4/attachment.html>


More information about the webkit-unassigned mailing list