[Webkit-unassigned] [Bug 195996] Geolocation request not complete when watch request was started in a different web process

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 08:36:38 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=195996

--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
(In reply to Carlos Garcia Campos from comment #6)
> (In reply to Chris Dumez from comment #5)
> > Comment on attachment 365542 [details]
> > Updated patch with unit test
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=365542&action=review
> > 
> > > Source/WebKit/Shared/WebProcessCreationParameters.cpp:170
> > > +    encoder << lastGeolocationPosition;
> > 
> > Why do we need to add yet another WebProcessCreationParameters ? If the page
> > want geolocation, they will ask for it and we'll ask the UIProcess.
> > I personally do not think it is worth adding a new
> > WebProcessCreationParameter just for this.
> 
> If the geolocation request has a maximum age option, and the cached position
> is recent enough we avoid asking the UI process for the location and the
> cached one is used instead. I assumed we wanted this because there's a FIXME
> in WebGeolocationClient::lastPosition().

Well, I do not think it is worth adding a new WebProcessCreationParameter just to avoid an IPC that might happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190322/07d01ae2/attachment.html>


More information about the webkit-unassigned mailing list