[Webkit-unassigned] [Bug 195879] Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyCoordinatedGraphics::incorporateUpdate when forceCompositingMode is turned on

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195879

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365008|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 365008
  --> https://bugs.webkit.org/attachment.cgi?id=365008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365008&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:545
> -    if (webViewBase->priv->acceleratedBackingStore && drawingArea->isInAcceleratedCompositingMode())
> +    if (webViewBase->priv->acceleratedBackingStore && (drawingArea->isInAcceleratedCompositingMode() || drawingArea->alwaysUseCompositing()))

I don't think we want to do this. If we are still transitioning, incorporateUpdate updated the backing store, so if at this point we haven't entered AC mode, we want to paint the new backing store, since the accelerated backing store won't have anything to paint yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190322/6904ed11/attachment.html>