[Webkit-unassigned] [Bug 196062] Certain WebProcesses should opt-out of the freezer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196062

--- Comment #11 from Brady Eidson <beidson at apple.com> ---
(In reply to Chris Dumez from comment #10)
> (In reply to Brady Eidson from comment #8)
> > (In reply to Chris Dumez from comment #6)
> > > (In reply to Brady Eidson from comment #1)
> > > > (In reply to Brady Eidson from comment #0)
> > > > > Certain WebProcesses should opt-out of the freezer
> > > > > 
> > > > > These include:
> > > > > -Prewarmed web processes
> > > > > -Processes in the per-domain-process cache
> > > > > -Processes in the back/forward cache list
> > > > 
> > > > Actually that last one is not true. It's "processes that *only host* pages
> > > > in the back/forward cache list" and such processes should also already be in
> > > > the per-domain-process-cache.
> > > > 
> > > > Yay.
> > > 
> > > Seems like we could generalize to:
> > > if (m_pageMap.isEmpty() && m_provisionalPages.isEmpty() &&
> > > !isServiceWorkerProcess())
> > >   // Then no need for the freezer.
> > 
> > I don't think the provisional page check is quite right.
> 
> Can you elaborate? :)

If a process *only* has a provisional page in it (e.g. it fails these other checks) there's no value to freezing it.

> > 
> > Also, serviceWorkerProcesses host pages (right?), so that explicit check is
> > also needed.
> 
> serviceWorkerProcesses host pages? This is news to me but maybe Youenn added
> a dummy page in there to help with the networking?

It's got the dummy page id for messaging, but the dummy page itself has been removed. I'll add the isServiceWorker check

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190321/3d93a8a2/attachment-0001.html>