[Webkit-unassigned] [Bug 195996] Geolocation request not complete when watch request was started in a different web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195996

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cdumez at apple.com

--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 365542
  --> https://bugs.webkit.org/attachment.cgi?id=365542
Updated patch with unit test

View in context: https://bugs.webkit.org/attachment.cgi?id=365542&action=review

> Source/WebKit/Shared/WebProcessCreationParameters.cpp:170
> +    encoder << lastGeolocationPosition;

Why do we need to add yet another WebProcessCreationParameters ? If the page want geolocation, they will ask for it and we'll ask the UIProcess.
I personally do not think it is worth adding a new WebProcessCreationParameter just for this.

> Source/WebKit/UIProcess/WebGeolocationManagerProxy.h:58
> +    Optional<WebCore::GeolocationPosition> lastPosition() const { return m_lastPosition; }

should return a const Optional<WebCore::GeolocationPosition>&

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190321/8b2c44e1/attachment-0001.html>