[Webkit-unassigned] [Bug 196016] webkit-patch upload doesn't run 'check-style-local' so doesn't find TestExpectations errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 10:57:07 PDT 2019


--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Looking a bit at the code and doing some local testing:

lint-test-expectations is weird because we have a whole bunch of defunct buildbot stuff sitting around in our code which defines ports automation is using. This stuff gets out of date super fast, and we shouldn't rely on it (lint-test-expectations does rely on it)

What's more, lint-test-expectations does really weird things with port object when you try and define it (via --ios-simulator, for example)

With all that being said, the core logic of lint-test-expectations is not the problem. Its port management is. I think looking at Simon's patch, 'lint-test-expectations' with no arguments might have actually flagged what he wanted it to.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190320/08ae65b5/attachment.html>

More information about the webkit-unassigned mailing list