[Webkit-unassigned] [Bug 195951] [GTK] REGRESSION(r243094): crash when launching minibrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 03:12:12 PDT 2019


--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Chris Dumez from comment #2)
> 3 ways we could fix this:
> 1. Update WebPageProxy::inspector() to return m_inspector even if
> !hasRunningProcess()
> 2. Update call site to not call inspector() until a load has been started
> (or null check as needed)
> 3. Add a call to launchInitialProcessIfNecessary() at the beginning of
> WebPageProxy::inspector() to maintain backward compatibility.
> A Web inspector person like Joe would likely know which way is best.
> Otherwise, I'd go with 3 because it is the safest. That said, it means that
> the client would not benefit in delayed WebProcess launch when making such a
> call (meaning that it would not be able to use the WebProcess cache).

I think 1 is safe enough. The WebInspectorProxy is created in WebPageProxy constructor, so it will always be available, and it's safe to use even before a process has been launched because m_inspectedPage is null-checked everywhere.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190320/6668a952/attachment.html>

More information about the webkit-unassigned mailing list