[Webkit-unassigned] [Bug 195988] New: Web Inspector: testCellRoleForRequiredChidren accessibility audit checks for rows in cells

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195988

            Bug ID: 195988
           Summary: Web Inspector: testCellRoleForRequiredChidren
                    accessibility audit checks for rows in cells
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon at simon.geek.nz
                CC: inspector-bugzilla-changes at group.apple.com

The `testCellRoleForRequiredChidren` accessibility audit currently checks to see if all elements with role=cell have a child with role=row. This is clearly the wrong way around.

The fix is to change the relationships object for `testCellRoleForRequiredChidren` in `WebInspectorUI/UserInterface/Controllers/AuditManager.js` to

```
const relationships = {
    row: ["cell", "gridcell", "columnheader", "rowheader"]
};
```

This will also require updating the test further down the same file and should probably include renaming the test to `testRowRoleForRequiredChidren`. There doesn't seem to be test cases that check the behaviour of the audits, so am not sure if one is needed.

I am planning on providing a patch once I have my dev environment set up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190320/643bd4d4/attachment-0001.html>