[Webkit-unassigned] [Bug 195947] REGRESSION(r243115) breaks build for clang 3.8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195947

--- Comment #4 from Xan Lopez <xan.lopez at gmail.com> ---
(In reply to Xan Lopez from comment #3)
> (In reply to Xan Lopez from comment #2)
> > I am guessing the std::move in WTFMove was redundant, but some of the other
> > extra stuff made the ctors in WTFString.h work in clang 3.8, and now we
> > fail? Somehow it seemingly works in other compilers though.
> 
> One guess is the std::forward call happening in move specialization in
> StdLibExtras.h, which could be forwarding the lvalue to match the WTFString
> ctor which takes a RefPtr<StringImpl>&&.

Adding std::forward<RefPtr<StringImpl>> fixes the build with clang 3.8, I asked someone with access to that to test it for me. My question now would be why it's not needed in newer clang versions, and whether that's safe to do regardless.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190319/cf7edbb3/attachment.html>