[Webkit-unassigned] [Bug 195940] [GTK][WPE] Add API to provide geolocation information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195940

--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #4)
> (In reply to Adrian Perez from comment #3)
> > Comment on attachment 365142 [details]
> > Patch
> > 
> > I did a quick skimming over the new API and it looks quite nice
> > to me. Just a quick question: Is there any reason why the WPE port
> > cannot use GeoClue if available? As far as I understand, GeoClue
> > itself does not depend on GTK. Of course, we can also enable using
> > it as an option in the WPE port with a follow-up patch :-)
> 
> No reason. I didn't add support for geoclue in this patch to WPE because I'm
> working on a patch to remove the build dependency on geoclue. We depend on
> geoclue only to generate code to talk to the DBus service. The code is
> simple enough to not need to auto-generate it, so it's better to simply use
> GDBus to talk to the Geoclue DBus service (if available). The patch will not
> have any build flag, so WPE will gain Geoclue support automatically.

That sounds great! No need to make this one patch enable the
support for GeoClue in WPE, then 👍

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190319/769aa091/attachment-0001.html>