[Webkit-unassigned] [Bug 195322] REGRESSION(r236862): early frame decoupling leaves JSC ArrayBuffer objects lingering

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 13:40:52 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=195322

--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
(In reply to Zan Dobersek from comment #6)
> The problem seems to be a lack of call to
> InspectorInstrumentation::frameWindowDiscarded(). Before r236862 this was
> called from Frame::willDetachPage(), through the FrameDestructionObserver
> interface.
> http://trac.webkit.org/browser/webkit/trunk/Source/WebCore/page/DOMWindow.
> cpp?rev=236862#L484
> 
> Starting in r236862 this was not being called anymore because DOMWindow was
> already decoupled from Frame when Frame::willDetachPage() was invoked and
> subsequently the m_destructionObservers set was empty.
> 
> The situation in trunk is similar, only difference is that after further
> refactoring the InspectorInstrumentation::frameWindowDiscarded() is now
> placed in Document::willDetachPage().

Then we probably need a call to InspectorInstrumentation::frameWindowDiscarded() in DOMWindow::willDetachDocumentFromFrame().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190314/ab1eefac/attachment-0001.html>


More information about the webkit-unassigned mailing list