[Webkit-unassigned] [Bug 195749] New: REGRESSION (r242801): [iOS] preventDefault() on touchstart in a subframe does not prevent focusing the subframe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 10:16:01 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=195749

            Bug ID: 195749
           Summary: REGRESSION (r242801): [iOS] preventDefault() on
                    touchstart in a subframe does not prevent focusing the
                    subframe
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wenson_hsieh at apple.com
                CC: wenson_hsieh at apple.com

This began after r242801, but it's really due to an existing (long-standing) bug wherein position information requests will change the focused frame:

InteractionInformationAtPosition WebPage::positionInformation(const InteractionInformationRequest& request)
{
    …

    if (!elementIsLinkOrImage) {
        HitTestResult result = m_page->mainFrame().eventHandler().hitTestResultAtPoint(request.point, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowUserAgentShadowContent | HitTestRequest::AllowChildFrameContent);
        hitNode = result.innerNode();
        // Hit test could return HTMLHtmlElement that has no renderer, if the body is smaller than the document.
        if (hitNode && hitNode->renderer()) {
            RenderObject* renderer = hitNode->renderer();
            m_page->focusController().setFocusedFrame(result.innerNodeFrame());
                                      ^^^^^^^^^^^^^^^
                                      This line in particular

            info.bounds = renderer->absoluteBoundingBoxRect(true);
            // We don't want to select blocks that are larger than 97% of the visible area of the document.

            …

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190314/fd1e6e4a/attachment.html>


More information about the webkit-unassigned mailing list