[Webkit-unassigned] [Bug 195743] Optimize Region for single rectangle case

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195743

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cdumez at apple.com

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 364659
  --> https://bugs.webkit.org/attachment.cgi?id=364659
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364659&action=review

>> Source/WebCore/platform/graphics/Region.h:226
>> +    decoder >> segmentIndex;
> 
> I don't really find this use of Optional<> and decoder >> much clearer than testing for decode success directly.

It's not really about readability though. The reason we changed the way we decode was to not require a default constructor for the classes being decoded.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190314/99c4d3b7/attachment.html>