[Webkit-unassigned] [Bug 195708] New: HTMLInputElement::setEditingValue should not fail if renderer doesn't exist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195708

            Bug ID: 195708
           Summary: HTMLInputElement::setEditingValue should not fail if
                    renderer doesn't exist
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Forms
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: cdumez at apple.com, wenson_hsieh at apple.com

HTMLInputElement::setEditingValue currently returns early if the element's renderer() is null. This is causing the Epiphany password manager to fail to remember passwords on https://www.geico.com/ except for navigations through page cache.

I traced this back to https://bugs.webkit.org/show_bug.cgi?id=85353#c15 trying to figure out why it was added in the first place and discovered it was to avoid some assertion, but I don't know which one, and there's definitely not any assertion hit nowadays in this case. Probably there are more guards checking if renderer() is null elsewhere in the code nowadays, closer to where it's really needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190313/282b4b69/attachment.html>