[Webkit-unassigned] [Bug 195638] [JSC] CodeBlock::visitChildren is reporting extra memory even when its JITCode is singleton

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195638

Caio Lima <ticaiolima at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|webkit-unassigned at lists.web |ticaiolima at gmail.com
                   |kit.org                     |

--- Comment #1 from Caio Lima <ticaiolima at gmail.com> ---
Created attachment 364435

  --> https://bugs.webkit.org/attachment.cgi?id=364435&action=review

RFC Patch

This change was used to create an alternative method to notify CodeBlock that it is referring to a shared m_jitCode. The flag `m_isSharedJITCode` is used to store such modification.

We ran Speedometer on minibrowser with JIT disabled to compare this approach. The results there are neutral.

Run 1:
ToT: 55.8 +- 1.0
Changes: 55.7 +- 1.0

Run 2:
ToT: 53.1 +- 0.69
Changes: 53.6 +- 0.49

Run 3:
ToT: 50.04 +- 0.65
Changes: 49.8 +- 0.58

I tried run some numbers on JetStream2, but with no JIT config, takes very long to run tests. It is probably very hard to see performance difference there, but I'll run other JS benchmarks to see difference on numbers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190312/bc9cd533/attachment-0001.html>