[Webkit-unassigned] [Bug 194147] [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194147

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360851|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 360851
  --> https://bugs.webkit.org/attachment.cgi?id=360851
Make --32-bit flag in build-jsc work in Linux/64bit

View in context: https://bugs.webkit.org/attachment.cgi?id=360851&action=review

> CMakeLists.txt:96
> +    if (FORCE_32BIT)

Ok as-is. Just a thought, add a comment to explain like what you did in the change log that this is a workaround/hack to support building 32 bit without having to formulate the build  as a crosscompile

> Tools/Scripts/webkitdirs.pm:2264
> +    if ($architecture eq "x86_64"  && shouldBuild32Bit()) {

Looks like an extra space character before the &&

> Tools/Scripts/webkitdirs.pm:2266
> +        # files in debian-based systems, for the others

Debian

> Tools/Scripts/webkitdirs.pm:2269
> +        push @cmakeArgs, '-DFORCE_32BIT=ON -DCMAKE_PREFIX_PATH="/usr" -DCMAKE_LIBRARY_ARCHITECTURE=x86';

Doesn't prefix path affect install path? If so, is that what we want? I don't understand the prefix path part.

> Tools/Scripts/webkitdirs.pm:2270
> +        $ENV{'CFLAGS'} = "-m32" . ($ENV{'CFLAGS'} || "");

More " please and less ' but only on this line and the below. The above line is perfect.

> Tools/Scripts/webkitdirs.pm:2271
> +        $ENV{'CXXFLAGS'} = "-m32" . ($ENV{'CXXFLAGS'} || "");

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190311/a585997c/attachment.html>