[Webkit-unassigned] [Bug 152480] ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 9 18:35:03 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=152480

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 364075
  --> https://bugs.webkit.org/attachment.cgi?id=364075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364075&action=review

> Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:62
> +    auto protectedProcessPool = makeRefPtr(m_process->processPool());

Since the DownloadProxyMap is owned by the NetworkProcessProxy, I think it would be clearer to ref m_process here:
auto protectedThis = makeRefPtr(m_process);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190310/c021e932/attachment-0001.html>


More information about the webkit-unassigned mailing list