[Webkit-unassigned] [Bug 195471] Web Inspector: CPU Usage Timeline - Enable by default

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 17:56:34 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=195471

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #364034|review?                     |review+
              Flags|                            |

--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 364034
  --> https://bugs.webkit.org/attachment.cgi?id=364034
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364034&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:113
> +        if (WI.CPUInstrument.supported())
> +            defaultTypes.push(WI.TimelineRecord.Type.CPU);

Should we put this above the FPS instrument, seeing as it's shown in the same grouping as the other default types (e.g. the rendering frame timeline is a separate "view"/"tab" from Network/Layout/Script)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190309/df9b29bd/attachment.html>


More information about the webkit-unassigned mailing list