[Webkit-unassigned] [Bug 195225] Check whether to launch a default action instead of action sheet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195225

--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 363942
  --> https://bugs.webkit.org/attachment.cgi?id=363942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363942&action=review

The refactoring is bad in my opinion and makes things worse. I think the right refactoring is everything except the target URL computation. Haven’t thought it through but I would rather take the duplication then this refactor

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:-564
> -    auto delegate = _delegate.get();

This looks like a bad refactor. Should check delegate in this function too.

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:604
> +        || !WebCore::DataDetection::canBePresentedByDataDetectors(targetURL)) return;

Formatting doesn’t look right. Grep code for examples or read style guide

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190307/924b2e92/attachment-0001.html>