[Webkit-unassigned] [Bug 195404] Run unit tests on remote machine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195404

Caio Lima <ticaiolima at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ticaiolima at gmail.com

--- Comment #2 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 363860
  --> https://bugs.webkit.org/attachment.cgi?id=363860
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363860&action=review

LGTM. I think it is a good idea to put on ChangeLog one example of how we can run these tests on command line. It will help a lot for future reference.

> Tools/ChangeLog:9
> +        with cross-compiled builds. Make the unit tests and JS files

I think we can change "Make the unit tests and JS files..." => "To enable remote run, we are making unit tests and JS files...".

> Tools/ChangeLog:14
> +        Avoid using `ldd` for retrieving JSC's dependencies, this does

I would use "..retrieving JSC's dependencies, since this does not work..."

> Tools/ChangeLog:16
> +        dependencies since changes should be quite rare anyway.

I would say: "As an alternative, we hardcode dependencies, since changes there are quite rare."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190307/c52d354f/attachment-0001.html>