[Webkit-unassigned] [Bug 195391] New: Remove an unneeded assert that was added with r242113

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195391

            Bug ID: 195391
           Summary: Remove an unneeded assert that was added with r242113
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ryanhaddad at apple.com

This assertion failure is seen with multiple layout tests after it was added in  https://trac.webkit.org/changeset/242113/webkit

ASSERTION FAILED: m_mediaBufferingIsSuspended
./page/Page.cpp(1784) : void WebCore::Page::resumeAllMediaBuffering()
1   0x493aeaee9 WTFCrash
2   0x497bb9c5b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x49a78750b WebCore::Page::resumeAllMediaBuffering()
4   0x102bea184 WebKit::WebPage::resumeAllMediaBuffering()
5   0x1028a83a6 WebKit::WebProcess::resumeAllMediaBuffering()
6   0x1028a8e2a WebKit::WebProcess::processDidResume()

see:
https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r242569%20(2612)/results.html


It doesn't seem necessary since m_mediaBufferingIsSuspended is protected by an 'if' statement right below the ASSERT:

void Page::resumeAllMediaBuffering()
{
#if ENABLE(VIDEO)
    ASSERT(m_mediaBufferingIsSuspended);
    if (!m_mediaBufferingIsSuspended)
        return;
...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190307/f6211f92/attachment.html>