[Webkit-unassigned] [Bug 195336] AX: Add remote search support for keyboard focusable element search type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 17:14:16 PST 2019


--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 363683
  --> https://bugs.webkit.org/attachment.cgi?id=363683

View in context: https://bugs.webkit.org/attachment.cgi?id=363683&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1163
> +    Element* element = this->element();

this seems like it could be in AccessibilityObject, then it doesn't have to be virtual

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1166
> +    return element->isFocusable();

this can be written like

if (Element* element = this->element())
   return element->isFocusable();

return false;

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190306/7fa031ae/attachment-0001.html>

More information about the webkit-unassigned mailing list