[Webkit-unassigned] [Bug 195317] Web Inspector: recordsInTimeRange sometimes does not get the expected record when includeRecordBeforeStart

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195317

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #363616|commit-queue-               |commit-queue+
              Flags|                            |

--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 363616
  --> https://bugs.webkit.org/attachment.cgi?id=363616
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=363616&action=review

>> Source/WebInspectorUI/UserInterface/Models/Timeline.js:116
>> +                lowerIndex--;
> 
> You could make this into a do-while :)

True, I thought this was clearer.

>> Source/WebInspectorUI/UserInterface/Models/Timeline.js:117
>> +                while (this._records[lowerIndex] !== recordBefore.parent)
> 
> Is it guaranteed that we'd eventually reach the parent record, or should we also add `&& this._records[lowerIndex].type === recordBefore.parent.type` so it's a bit more restrictive?

We already did this check up above: `recordBefore.parent && recordBefore.parent.type === recordBefore.type`.

Once they are the same type, then yes it should be guaranteed that the parent is in the list (it should have started earlier then the child).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190306/370314b4/attachment.html>