[Webkit-unassigned] [Bug 195317] Web Inspector: recordsInTimeRange sometimes does not get the expected record when includeRecordBeforeStart

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195317

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #363616|review?                     |review+
              Flags|                            |

--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 363616
  --> https://bugs.webkit.org/attachment.cgi?id=363616
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=363616&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Timeline.js:116
> +                lowerIndex--;

You could make this into a do-while :)

> Source/WebInspectorUI/UserInterface/Models/Timeline.js:117
> +                while (this._records[lowerIndex] !== recordBefore.parent)

Is it guaranteed that we'd eventually reach the parent record, or should we also add `&& this._records[lowerIndex].type === recordBefore.parent.type` so it's a bit more restrictive?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190305/b5f7eb89/attachment.html>