[Webkit-unassigned] [Bug 195318] Web Inspector: Attempting to select records in the bottom 16px of the timeline overview graph fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 02:11:25 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=195318

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com

--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 363617
  --> https://bugs.webkit.org/attachment.cgi?id=363617
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=363617&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:541
> +        this.element.classList.toggle("has-scrollbar", this._scrollContainerElement.clientHeight <= 1);

Am I misreading this, or should we flip the `<=` to be a `>`?  We only `has-scrollbar` when the height is `<= 1`?  Wouldn't the scrollbar make the height larger, or am I thinking backwards?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190305/aa69616f/attachment.html>


More information about the webkit-unassigned mailing list