[Webkit-unassigned] [Bug 195319] Web Inspector: TimelineOverview clicks do not always behave as expected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195319

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com

--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 363618
  --> https://bugs.webkit.org/attachment.cgi?id=363618
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=363618&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:759
> +        if (pixels <= 4)

If the user has moved the mouse more than 4px (e.g. they jerk their wrist), should that be considered a pass?

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:781
> +            let subEvent = new event.constructor(event.type, event);

I'd name this `newEvent` (it matches `newTarget`).

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:784
> +                event.stop();

Do we want to `stop`, or just set `__timelineRecordClick` on `newEvent` if it had previously been set on `event`?  Also, considering that we're trying to dispatch the event on a new target, shouldn't we `stop` the old event regardless?

    let newEvent = new event.constructor(event.type, event);
    if (event.__timlineRecordBarClick)
        newEvent.__timelineRecordBarClick = event.__timelineRecordBarClick;

    event.stop();

    newTargete.dispatchEvent(newEvent);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190305/55bbcc0d/attachment.html>