[Webkit-unassigned] [Bug 195276] Rename AtomicString to AtomString

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 10:04:18 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=195276

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Darin Adler from comment #2)
> Although we might need to do some trial runs and fix bugs in the script.
> 
> I’ve done similarly-broad giant renames with that script before.

Cool script. Note its output when not given anything new to rename:

diff --git a/Source/WTF/wtf/Expected.h b/Source/WTF/wtf/Expected.h
index e9b0ec9f9e6..b64f69ecdab 100644
--- a/Source/WTF/wtf/Expected.h
+++ b/Source/WTF/wtf/Expected.h
@@ -214,7 +214,7 @@ template<class E>
 class bad_expected_access : public bad_expected_access<void> {
 public:
     explicit bad_expected_access(E val) : val(val) { }
-    virtual const char* what() const noexcept override { return std::exception::what(); }
+    const char* what() const noexcept override { return std::exception::what(); }
     E& error() & { return val; }
     const E& error() const& { return val; }
     E&& error() && { return std::move(val); }

(A code style error.)

diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h
index 94037ce8e29..369d2344d98 100644
--- a/Source/WTF/wtf/Platform.h
+++ b/Source/WTF/wtf/Platform.h
@@ -353,7 +353,7 @@
 #endif

 /* ==== OS() - underlying operating system; only to be used for mandated low-level services like 
-   virtual memory, not to choose a GUI toolkit ==== */
+   memory, not to choose a GUI toolkit ==== */

 /* OS(AIX) - AIX */
 #ifdef _AIX

(A do-webcore-rename issue.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190304/dcaf5f6c/attachment-0001.html>


More information about the webkit-unassigned mailing list