[Webkit-unassigned] [Bug 194830] [WPE] Do not create a PlatformDisplay in the Service Worker process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194830

--- Comment #16 from Zan Dobersek <zan at falconsigh.net> ---
(In reply to Loïc Yhuel from comment #15)
> (In reply to Zan Dobersek from comment #14)
> > Comment on attachment 363167 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=363167&action=review
> > 
> > > Source/WebKit/Shared/WebProcessCreationParameters.h:207
> > > +#if ENABLE(SERVICE_WORKER)
> > > +    bool isServiceWorkerProcess { false };
> > > +#endif
> > 
> > Let's rename this to `isWPEClient`, and place it above the other two member
> > variables here. Decoding/encoding sequencing should follow this order. It
> > should also default to true, and not be guarded with ENABLE(SERVICE_WORKER).
> > 
> Then, should it be tested for implementationLibraryName usage too (ie not
> calling wpe_loader_init in the Service Worker process) ?
> 

Yes, the wpe_loader_init() call should also be avoided.

> The specific `isWPEClient` name might not be appropriate if we later find
> other things we can skip for Service Workers : for example the
> `WebCore::initializeGStreamer` in `WebProcess::platformInitializeWebProcess`
> is probably not needed.

Makes sense. We can use the current name and expand its use over GStreamer in a future patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190304/b31b9707/attachment-0001.html>