[Webkit-unassigned] [Bug 195208] [ThreadedCompositor] Simplify the compositing run loop worker thread
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 4 01:47:43 PST 2019
https://bugs.webkit.org/show_bug.cgi?id=195208
--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 363328
--> https://bugs.webkit.org/attachment.cgi?id=363328
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=363328&action=review
>> Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:76
>> + });
>
> Why do you dispatch twice?
> Can this code be simplified like the following?
>
> m_runLoop->dispatch([] {
> RunLoop::current().stop();
> });
No, we used to get a crash if the run loop was stopped before the timer was destroyed. So, we stop the run loop in the next main frame iteration. See bug #167545. Maybe it's no longer needed now that we don't use a WorkQueue.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190304/f30c0d47/attachment.html>
More information about the webkit-unassigned
mailing list