[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 01:09:35 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #62 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #53)
> Comment on attachment 363211 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363211&action=review
> 
> > Source/WebCore/platform/network/curl/CookieJarDB.cpp:319
> > +    if (firstParty == url)
> 
> Checking URLs seems useless. How about checking hosts?
> if (firstParty.host() == url.host())

Fixed.

> > Source/WebCore/platform/network/curl/CookieJarDB.cpp:360
> > +    if (!checkCookieAcceptPolicy(firstParty, requestUrl))
> 
> I think this condition should be moved after the following condition "if
> (requestHost.isEmpty())" for efficiency.

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190304/d7b7b0a5/attachment.html>


More information about the webkit-unassigned mailing list