[Webkit-unassigned] [Bug 193806] [PlayStation] Upstream playstation's remote inspector server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193806

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #40 from Darin Adler <darin at apple.com> ---
Comment on attachment 362940
  --> https://bugs.webkit.org/attachment.cgi?id=362940
Inspector Server

View in context: https://bugs.webkit.org/attachment.cgi?id=362940&action=review

>> Source/JavaScriptCore/inspector/remote/playstation/RemoteInspectorSocketClientPlayStation.cpp:48
>> +    saServer.sin_family = AF_INET;
> 
> The names in here that are abbreviations are unusual for WebKit style (`saServer`, `ret`).
> 
> Normally I see initialization with memset:
> 
>     memset(&saServer, 0, sizeof(struct sockaddr_in));
> 
> I'm not sure if the { 0 } alone would be enough.

I am almost sure that { 0 } style will work, and it is pretty common in Windows code, but not a common idiom outside Windows as far as I know. I believe that in Modern C++ it can just be { }.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190302/e96de17c/attachment.html>