[Webkit-unassigned] [Bug 199209] [Catalina] Enable WebKit build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 27 11:21:20 PDT 2019


--- Comment #19 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 372970
  --> https://bugs.webkit.org/attachment.cgi?id=372970

View in context: https://bugs.webkit.org/attachment.cgi?id=372970&action=review

>>> Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:215
>>> +#endif
>> Surprised a protected field is SPI. And surprised that defining it in a category does the right thing. Are you sure this technique is correct? Gets a binary that works, not just compiles?
>> Also, if we have something this tricky, I think it eventually needs to move into an SPI header, not just in a .mm file, and especially not in two different .mm files.
> As far as I can tell, the binaries work, but I only ran API tests.
> I would like to know if anyone else knows more about these protected NSView and NSWindow bits, because what's even more surprising is that these were available in the Mojave headers (if you look, usage of _subviews and _borderView isn't protected by Catalina macros). This seems to get everything working, but I agree that it doesn't seem quite right.

The _subviews ivar is still there, just not published in the public header anymore. It is published in the internal SDK version of the header. However, putting this in a category likely builds but fails to do what we expect.

I forgot we asked AppKit to add a method to let us set this ivar (and they added it in Catalina). We should use that instead. I'll post a patch for that on bug 199279.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190627/0b578d32/attachment.html>

More information about the webkit-unassigned mailing list