[Webkit-unassigned] [Bug 199216] Enhance support of aria-haspopup per ARIA 1.1 specification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199216

--- Comment #9 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to chris fleizach from comment #2)
> Comment on attachment 372892 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372892&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2767
> > +    if (equalLettersIgnoringASCIICase(hasPopup, "dialog"))
> 
> should we make a static HashSet of valid values and then just check based on
> passing in the popupAttr.lowercaseString() ?

Thanks for the suggestion. Using HashSet in latest patch. Doesn't buy us much in terms of performance, but code is more elegant and compact. Still have to handle a couple of cases separately. Was looking for an equivalent to boost::hana strings in WTF, but couldn't find it. boost::hana would be ideal for cases like this because the hana strings are as efficient as literals but the set also have the searching capabilities like contains.

Also fixed the DumpRenderTree build and test in latest upload.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190627/cdc8a73d/attachment.html>