[Webkit-unassigned] [Bug 199200] Web Inspector: Implement console.countReset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199200

--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 372856
  --> https://bugs.webkit.org/attachment.cgi?id=372856
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=372856&action=review

>> Source/JavaScriptCore/inspector/agents/InspectorConsoleAgent.cpp:211
>> +void InspectorConsoleAgent::getCounterLabel(Ref<ScriptArguments>&& arguments, String& title, String& identifier)
> 
> Maybe return a `std::pair` or a custom `struct` instead?  I don't like out-arguments :(

I haven't seen that happening in a lot of places. In fact this function makes use of an out string already (getFirstArgumentAsString). Maybe that is a new norm?

>> Source/JavaScriptCore/inspector/agents/InspectorConsoleAgent.cpp:263
>> +    // FIXME: Web Inspector should have a better UI for counters, but for now we just log an updated counter value.
> 
> This isn't technically true, as we don't log anything when we call `console.countReset` :P

A better UI might inform the frontend that the counter reset to zero so the frontend could update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190626/87979a49/attachment-0001.html>