[Webkit-unassigned] [Bug 199211] Selection highlight not shown on programmatic focus after initial load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199211

--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
(In reply to Build Bot from comment #2)
> Comment on attachment 372874 [details]
> First stab
> 
> Attachment 372874 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/12575966
> 
> New failing tests:
> editing/selection/selection-across-shadow-boundaries-readonly-2.html
> imported/mozilla/svg/text/selectSubString-3.svg
> fast/flexbox/flexbox-fail-to-select-same-line.html
> editing/selection/update-selection-by-style-change.html
> fast/text/international/hebrew-selection.html
> fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed.html
> svg/masking/mask-should-not-paint-selection.html
> imported/blink/editing/selection/deleteFromDocument-crash.html
> imported/mozilla/svg/text/multiple-chunks-selection.svg
> fast/dynamic/remove-invisible-node-inside-selection.html
> imported/mozilla/svg/text/selectSubString.svg
> fast/dynamic/remove-node-inside-selection.html

These "failures" reveal various bugs in our code! Only one of the failures may indicate the patch is not quite right: svg/masking/mask-should-not-paint-selection.html, but quick glance at this test makes me think the mechanism to prevent selection is not enabled on iOS and the only reason we've been passing this test is because we do not paint selection on first load.

^^^ that last part is the reason for other failures in this list like fast/text/international/hebrew-selection.html. That is, we've been passing this test because both sides of the comparison have been broken. I fixed the -expected.html side, which uses programmatic selection API. The non-expected side used window.eventSender, which is known to be broken in WebKit2 on iOS. Haha

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190626/4b021772/attachment-0001.html>