[Webkit-unassigned] [Bug 199209] [Catalina] Enable WebKit build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199209

--- Comment #5 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 372876
  --> https://bugs.webkit.org/attachment.cgi?id=372876
patch-2

View in context: https://bugs.webkit.org/attachment.cgi?id=372876&action=review

The AppSSO part looks good to me.

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:202
> +#if HAVE(APP_SSO)

Good catch!

> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.h:30
> +#include <pal/spi/cocoa/AppSSOSPI.h>

Good catch!

> Tools/TestWebKitAPI/Configurations/Base.xcconfig:118
> +WK_PRIVATE_FRAMEWORKS_DIR = $(WK_PRIVATE_FRAMEWORKS_DIR_$(USE_INTERNAL_SDK));

Do we need to remove the LDFLAG WK_AUTHKIT_LDFLAGS in TestWebKitAPI.xcconfig?

Also, maybe we should move this to TestWebKitAPI.xcconfig?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190626/de1d9611/attachment.html>