[Webkit-unassigned] [Bug 199151] [SOUP] Use libsoup WebSockets API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199151

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to youenn fablet from comment #5)
> (In reply to Carlos Garcia Campos from comment #1)
> > Created attachment 372750 [details]
> > WIP
> > 
> > This is a WIP patch. Old code is used unless WEBKIT_USE_SOUP_WEBSOCKETS env
> > var is present. This is just temporary until the implementation is complete
> > and we make layout tests pass. Most of them are failing with the patch, but
> > in a lot of cases it's because of missing console messages that new code
> > path doesn't generate. I'll add a comment with more information about the
> > layout tests.
> 
> Depending on how you want to do the switch, it might be feasible to
> rename/reuse NSURLSessionWebSocket runtime flag.

We already depend on a lisboup version having the websockets API (although I've fixed several bugs these days while working on it, but mostly edge cases covered by the tests). So, as soon as we have all the basic functionality working we can do the switch unconditionally. I can use platform specific test results until apple switches to use NSURLSession for the tests too. We can probably land this patch using the env var and continue working on the remaining issues in follow up patches.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190625/c827a911/attachment.html>