[Webkit-unassigned] [Bug 198518] [GTK] [2.25.1] static assertion failed: Match result and EncodedMatchResult should be the same size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198518

Eike Rathke <erack at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372782|                            |review+
              Flags|                            |

--- Comment #5 from Eike Rathke <erack at redhat.com> ---
Created attachment 372782

  --> https://bugs.webkit.org/attachment.cgi?id=372782&action=review

proposed patch

It is unclear to me why in Source/JavaScriptCore/runtime/MatchResult.h the EncodedMatchResult should depend on CPU, but clearly with

  using EncodedMatchResult = uint64_t;

and

  static_assert(sizeof(MatchResult) == sizeof(EncodedMatchResult))

and the two size_t member variables of MatchResult that can compile only if size_t is 32-bit and the member variables aligned. So the straight forward change would be to do exactly that, but I don't know if there is a reason to have CPU type involved here (because of JIT asm).

Attached is a tad ugly patch which on ppc64le at least compiles.

Does that suit the purpose? If yes, I can create a ready-to-commit patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190624/f9736786/attachment.html>