[Webkit-unassigned] [Bug 198604] Refactoring of architectural Register Information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198604

--- Comment #53 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 372051
  --> https://bugs.webkit.org/attachment.cgi?id=372051
Post-3 Review Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372051&action=review

lgtm other than updating that comment.

> Source/JavaScriptCore/assembler/RegisterInfo.h:45
> + * = 1. id: is an identifier used to specify the register (for example, as an enumerator
> + * in an enum);
> + * = 2. nsid: is an identifier specifying the full namespace identifier literal for id;
> + * = 3. name: is a string constant specifying the name of the identifier;
> + * = 4. isReserved: a boolean (usually 0/1) specifying if this is a reserved register;
> + * = 5. isCalleeSaved: a boolean (usually 0/1) specifying if this is a callee saved register;

I think you need to update these comments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190624/5376e5ac/attachment.html>