[Webkit-unassigned] [Bug 199161] New: contributors.json not canonicalized since r243297

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199161

            Bug ID: 199161
           Summary: contributors.json not canonicalized since r243297
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: ap at webkit.org

"status" : "contributor", added all over the place in r243297 "Update status inactive committers' status to 'contributor'," isn't recognized as canonical format by validate-committer-lists --canonicalize. Canonicalizing contributors.json will result in the removal of "status" : "contributor" wherever it exists.

We could make it canonical form with this simple tweak:

diff --git a/Tools/Scripts/webkitpy/common/config/committers.py b/Tools/Scripts/
webkitpy/common/config/committers.py
index ed927ba52ea..c446ce53a04 100644
--- a/Tools/Scripts/webkitpy/common/config/committers.py
+++ b/Tools/Scripts/webkitpy/common/config/committers.py
@@ -142,6 +142,8 @@ class Contributor(object):
             info["status"] = "reviewer"
         elif self.can_commit:
             info["status"] = "committer"
+        else:
+            info["status"] = "contributor"

         if self.irc_nicknames:
             info["nicks"] = self.irc_nicknames

Or we could just remove it everywhere. Alexey, your preference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190624/468cbe56/attachment-0001.html>