[Webkit-unassigned] [Bug 199151] [SOUP] Use libsoup WebSockets API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199151

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
As I said most of the tests are failing because of missing console messages, so they are actually working and I won't mention them here.

http/tests/websocket/tests/hybi/bad-handshake-crash.html

This needs investigation, "WebSocket is open" message is unexpectedly shown in the output.

http/tests/websocket/tests/hybi/client-close.html

I've debugged this and I don't understand why it fails, the diff is:
-PASS closeEvent.reason is "close_frame[:2]='\\x88\\x80'"
+FAIL closeEvent.reason should be close_frame[:2]='\x88\x80'. Was close_frame[:2]='\x88\x82'.

http/tests/websocket/tests/hybi/close-code-and-reason.html

This one expects error codes that the spec says shouldn't be used like 1006. But close reason is also failing, so it needs some more investigation.

http/tests/websocket/tests/hybi/close.html

It seems onclose is not called in a couple of cases.

http/tests/websocket/tests/hybi/deflate-frame-parameter.html
http/tests/websocket/tests/hybi/extensions.html

x-webkit-deflate-frame extension not supported

http/tests/websocket/tests/hybi/handshake-fail-by-no-cr.html

Libsoup doesn't fail when status line finishes with \n since that's what the http spec suggests.

http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1.html

There are a couple of cases where libsoup doesn't fail either.

http/tests/websocket/tests/hybi/inspector/*

It seems we are not notifying the inspector in some cases about websockets with the new code path.

http/tests/websocket/tests/hybi/null-character.html

libsoup API always expect a null terminated string for text frames. I haven't found anything in the spec about it, it just says that text frames should contains valid utf8, and null character si perfectly valid, so maybe we need to add new API in libsoup to allow passing char* + length.

http/tests/websocket/tests/hybi/send-object-tostring-check.html

It expects to be closed cleanly, but apparently it isn't.

http/tests/websocket/tests/hybi/simple-wss.html

We don't have a way to accept the invalid certificate only for tests.

http/tests/websocket/tests/hybi/inspector/binary.html
http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html
http/tests/websocket/tests/hybi/send-blob.html

Blobs are not implemented in new code path.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190624/ac5bc0a3/attachment.html>