[Webkit-unassigned] [Bug 199107] Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199107

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 372628
  --> https://bugs.webkit.org/attachment.cgi?id=372628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372628&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1035
> +    // If this has a link ancestor, check for the aria-haspopup attribute in the ancestor.

I think we can write this whole method as

return AccessibilityObject::matchedParent(*this, true, [&role] (const AccessibilityObject& object) {
        return !equalLettersIgnoringASCIICase(object.hasPopupValue()), "false");
    });

> LayoutTests/accessibility/ios-simulator/button-with-aria-haspopup-role-expected.txt:15
> +test10 AXTraits: 8256 for aria-haspopup=''

it's probably risky to output the actual value of the traits which may change over time. maybe better to verify that the traits are different for an object that has popup and one that does not

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190621/1f1fd4d7/attachment-0001.html>