[Webkit-unassigned] [Bug 199104] [GTK] Navigation gesture should use dark fallback bg color on dark themes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 21 07:03:17 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |mcatanzaro at igalia.com

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372621
  --> https://bugs.webkit.org/attachment.cgi?id=372621

View in context: https://bugs.webkit.org/attachment.cgi?id=372621&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:322
> +        gtk_style_context_lookup_color(context, "theme_base_color", &color);

Is this an Adwaita-ism? What happens if the theme doesn't have a theme_base_color? Will the GdkRGBA contain uninitialized memory? Do we need a fallback?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190621/04b203ce/attachment.html>

More information about the webkit-unassigned mailing list